Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #486 Fix cran checks #505

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Issue #486 Fix cran checks #505

merged 4 commits into from
Nov 27, 2023

Conversation

nikosbosse
Copy link
Contributor

@nikosbosse nikosbosse commented Nov 25, 2023

Fixes #486

This PR fixes a problems that I encountered during CRAN submission (several NOTEs on winbuilder). In particular:

  • fixes a link to the European Forecast Hub github repo which has changed
  • fixes a broken link in the package documentation
  • fixes an issue with spell checking (see below)

While checking the package on Winbuilder, I got the following note:

Possibly misspelled words in DESCRIPTION:
Bosse (45:25)
al (45:34)
et (45:31)
scoringutils (44:50)

So I added those words to inst/WORDLIST which I hoped would fix the issue (all other names like Eggo etc. are there and it seems fine). That didn't work so eventually I just reworded it and dropped the names. Since CRAN is always right I guess that's the easiest (although not ideal) way to solve this.

During checking I also sometimes got this NOTE:

Found the following (possibly) invalid DOIs:
DOI: 10.1198/016214506000001437

I checked the DOI and it is correct. I also didn't get this consistently, so maybe it's just a fluke. A similar note was the reason I also changed the link to the scoringutils paper from <arxiv> to <doi>

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ac4fc9) 90.92% compared to head (2e8b824) 90.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #505   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files          23       23           
  Lines        1399     1399           
=======================================
  Hits         1272     1272           
  Misses        127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse mentioned this pull request Nov 25, 2023
@nikosbosse nikosbosse requested a review from seabbs November 26, 2023 09:19
@seabbs
Copy link
Contributor

seabbs commented Nov 27, 2023

That didn't work so eventually

I don't understand why this wouldn't work?

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs merged commit 3fa5741 into main Nov 27, 2023
11 checks passed
@seabbs seabbs deleted the fix-cran-checks branch November 27, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRAN release
2 participants