Issue #446: Remove function delete_columns()
#529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #446
We have a helper function
delete_columns()
that safely deletes columns from adata.table
. Recent changes indata.table
mean that you can attempt to delete a column that doesn't exist without an error. So this PR changes instances ofdelete_columns()
withsuppressWarnings(dt[, col := NULL])
Linting CI is currently failing since #511 that fixes the variable length is not yet merged.
Checklist
I have added or updated unit tests where necessary.I have updated the documentation if required.lintr::lint_package()
to check for style issues introduced by my changes.I have added a news item linked to this PR.