Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 551: Remove scoringutils metrics as using Metrics versions #548

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Jan 5, 2024

As it says on the tin this PR removes all point metrics in favour of those from the Metrics package. Closes #551

Note this is a breaking change if users were making use of the lower level rules but should have limited to no impact to most users that are working through score.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9871994) 83.71% compared to head (8c35bec) 83.90%.
Report is 12 commits behind head on develop.

❗ Current head 8c35bec differs from pull request most recent head 10641d6. Consider uploading reports for the commit 10641d6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #548      +/-   ##
===========================================
+ Coverage    83.71%   83.90%   +0.18%     
===========================================
  Files           22       20       -2     
  Lines         1726     1715      -11     
===========================================
- Hits          1445     1439       -6     
+ Misses         281      276       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs requested a review from nikosbosse January 5, 2024 11:27
@seabbs seabbs changed the title Remove scoringutils metrics as using Metrics versions Issue 551: Remove scoringutils metrics as using Metrics versions Jan 5, 2024
@nikosbosse
Copy link
Contributor

Looks good, thank you!

@nikosbosse nikosbosse merged commit 52e2cb8 into develop Jan 5, 2024
9 of 10 checks passed
@nikosbosse nikosbosse deleted the test-metrics-point branch January 5, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants