Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for interval_coverage_quantile() #549

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

nikosbosse
Copy link
Contributor

Description

The previous version had a typo:

1: In (function (observed, predicted, quantile, range = 50)  :
  To compute the interval coverage for a range of 50%, the quantiles 0.250.75 are required. Returning `NA`.

This PR fixes this so that the message now reads:

1: In (function (observed, predicted, quantile, range = 50)  :
  To compute the interval coverage for a range of 50%, the quantiles `0.25, 0.75` are required. Returning `NA`.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2ff165f) 83.71% compared to head (a88369c) 83.66%.

Files Patch % Lines
R/metrics-quantile.R 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #549      +/-   ##
===========================================
- Coverage    83.71%   83.66%   -0.05%     
===========================================
  Files           21       21              
  Lines         1719     1720       +1     
===========================================
  Hits          1439     1439              
- Misses         280      281       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse requested a review from seabbs January 5, 2024 11:51
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha I was just looking at this in the testing update.

@seabbs seabbs merged commit e43e008 into develop Jan 5, 2024
9 of 11 checks passed
@seabbs seabbs deleted the fix-error-messages branch January 5, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants