-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #851 - Create S3 methods for converting to point and quantile forecasts #876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. The new interface is starting to feel really slick. A few comments about the s3 setup that can be handled in another issue and a few depreciated arg that have slipped through
Merge remote-tracking branch 'origin/main' into as_quantile_new # Conflicts: # R/utils_data_handling.R # man/sample_to_quantile.Rd
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
==========================================
- Coverage 95.47% 95.20% -0.27%
==========================================
Files 21 21
Lines 1568 1606 +38
==========================================
+ Hits 1497 1529 +32
- Misses 71 77 +6 ☔ View full report in Codecov by Sentry. |
I think I successfully addressed all points by deferring them to new issues :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
Description
This PR closes #851.
The PR
as_forecast_point()
andas_forecast_quantile
to convert quantile-based and sample-based forecastsas_forecast()
.?as_forecast()
now has the overview of all the types and there are separate entries for all the specificas_forecast_<type>()
functions. In the future we could flesh them out more, but at the moment it's not top on my priority listChecklist
lintr::lint_package()
to check for style issues introduced by my changes.