Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #481: Update pkgdown structure #886

Merged
merged 4 commits into from
Aug 10, 2024
Merged

Issue #481: Update pkgdown structure #886

merged 4 commits into from
Aug 10, 2024

Conversation

nikosbosse
Copy link
Contributor

Description

This PR closes #481 by reorganising the pgkdown function categories, broadly following the structure outlined in the paper.

In addition, there are some minor fixes like

  • fixing the doi rendering in the DESCRIPTION
  • fixing the CRAN downloads badge

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse requested a review from seabbs August 10, 2024 10:53
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (4fee240) to head (25c59e9).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
+ Coverage   95.47%   98.84%   +3.37%     
==========================================
  Files          21       21              
  Lines        1568     1556      -12     
==========================================
+ Hits         1497     1538      +41     
+ Misses         71       18      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse
Copy link
Contributor Author

I'm going to go ahead and merge this as there isn't really any substantial code change here and I want to make progress with #837.

image

I mean apologies.

Also I'd still be interested whether you think the pkgdown categories broadly make sense.

@nikosbosse nikosbosse merged commit a62899f into main Aug 10, 2024
9 checks passed
@nikosbosse nikosbosse deleted the update-pkgdown branch August 10, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: Which pkgdown function categories do we want to have?
1 participant