-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #832 - Make default metrics function S3 #903
Conversation
Good call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how this has turned out. I can think of a few uses cases where this might annoy people (if they don't have an object of the right class but want the list) but think that overall should be a much better user experience.
yeah me too. In that sense I think changing the examples to pre-validated was a good move |
Description
This PR closes #832.
Creates a single
get_metrics()
generic with S3 methods forforecast
andscores
objects.Additional comments:
Checklist
lintr::lint_package()
to check for style issues introduced by my changes.