Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #900: Remove observed and predicted columns from output for point and binary forecasts #904

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

nikosbosse
Copy link
Contributor

Description

This PR closes #900.

Does what it says on the tin.

Not sure whether we need to add a news item

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse requested a review from seabbs September 11, 2024 18:48
@seabbs seabbs force-pushed the remove-observed-predicted branch from 3b1cf46 to b4f00d9 Compare September 12, 2024 17:38
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree and I don't think we do

@seabbs seabbs merged commit 7fa754a into main Sep 12, 2024
9 checks passed
@seabbs seabbs deleted the remove-observed-predicted branch September 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove observed and predicted from scoring output for binary and point forecasts
2 participants