Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

359: convert get_pit() to S3 #910

Merged
merged 2 commits into from
Sep 16, 2024
Merged

359: convert get_pit() to S3 #910

merged 2 commits into from
Sep 16, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Sep 16, 2024

Description

This PR is an intermediate step towards addressing #359 as mentioned in #359 (comment).

It turns get_pit() into an S3 function so an appropriate method can be chosen according to how the predictive distribution is represented.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs seabbs requested a review from nikosbosse September 16, 2024 12:51
@seabbs seabbs enabled auto-merge (squash) September 16, 2024 13:02
@seabbs seabbs self-requested a review September 16, 2024 13:02
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Much nicer.

@seabbs seabbs merged commit 1f4f36e into main Sep 16, 2024
8 of 9 checks passed
@seabbs seabbs deleted the pit-s3 branch September 16, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants