Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette typos #970

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Conversation

jcken95
Copy link
Contributor

@jcken95 jcken95 commented Nov 1, 2024

Description

This PR closes #969

  • Fix mathematical error in interval coverage section
  • Fix some spelling errors

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.
  • NOTE: linter failed, but unrelated to PR

@nikosbosse
Copy link
Contributor

Ah sweet, thanks a lot for fixing this!

@jcken95 jcken95 changed the title Vig scoring interval typo Vignette typos Nov 1, 2024
@jcken95 jcken95 marked this pull request as ready for review November 1, 2024 11:25
@jcken95
Copy link
Contributor Author

jcken95 commented Nov 1, 2024

No worries! Marking as ready despite failing pipeline - it's not related to this PR

@nikosbosse
Copy link
Contributor

Yeah I've seen this linting error all morning. Happy to merge whenever you're ready!

@jackUKHSA
Copy link

yep, go ahead :)

@jackUKHSA
Copy link

I think this is the error btw RcppCore/Rcpp#1341

@nikosbosse
Copy link
Contributor

Merging now. Thank you very much for your first contribution to scoringutils! If you feel like it, feel invited to add yourself as a contributor to the package. We're always happy about contributions!

@nikosbosse nikosbosse merged commit 642b0ef into epiforecasts:main Nov 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mathematical error in scoring rules vignette
3 participants