Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tidyselect deprecation warnings #206

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix tidyselect deprecation warnings #206

merged 1 commit into from
Feb 10, 2025

Conversation

Karim-Mane
Copy link
Member

This PR contains changes to fix the tidyselect deprecation warnings.

@Karim-Mane Karim-Mane added the enhancement New feature or request label Feb 6, 2025
@Karim-Mane Karim-Mane self-assigned this Feb 6, 2025
@Karim-Mane Karim-Mane linked an issue Feb 6, 2025 that may be closed by this pull request
Resolve tidyselect deprecation warnings #153
Closed
@Karim-Mane Karim-Mane removed a link to an issue Feb 6, 2025
Resolve tidyselect deprecation warnings #153
Closed
This was linked to issues Feb 6, 2025
Noisy tests (incl. backtraces) makes assessing them hard #159
Closed
Resolve tidyselect deprecation warnings #153
Closed
Bisaloo
Bisaloo approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fixes #153.

My recommendation would be to leave #159 open because there are still a number of messages that are not silenced that make the test outputs a bit too verbose in my opinion.

@Karim-Mane Karim-Mane merged commit 1f496e2 into main Feb 10, 2025
8 checks passed
@Karim-Mane Karim-Mane deleted the fix-issue-153 branch February 10, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bisaloo Bisaloo Bisaloo approved these changes

@chartgerink chartgerink Awaiting requested review from chartgerink

Assignees

@Karim-Mane Karim-Mane

Labels
enhancement New feature or request
Projects
cleanepi
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noisy tests (incl. backtraces) makes assessing them hard Resolve tidyselect deprecation warnings
2 participants
@Karim-Mane @Bisaloo