Support for ireland #122
Support for ireland #122
Conversation
|
Thanks for adding support for Ireland! I will review shortly. |
There was a problem hiding this comment.
This looks great, thanks for working on it! Here are a few general comments that didn't belong with the rest of the code in this PR:
- there are some static analysis errors;
- update these two faqs as well: https://github.com/eprbell/rp2/blob/main/docs/user_faq.md#what-accounting-methods-are-supported and https://github.com/eprbell/rp2/blob/main/docs/user_faq.md#what-countries-are-supported;
- optional: consider adding an IE plugin to Dali as well.
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: rp2 1.4.2\n" |
There was a problem hiding this comment.
Project version seems old: should be 1.5.1.
src/rp2/plugin/country/ie.py
Outdated
| @@ -0,0 +1,54 @@ | |||
| # Copyright 2021 eprbell | |||
There was a problem hiding this comment.
The year should be 2024 (year of creation of this file). Also use your name in the copyright line (by convention throughout the repo new files use the name of the creator).
| @@ -0,0 +1,199 @@ | |||
| # Copyright 2021 eprbell | |||
tests/test_ods_output_diff_ie.py
Outdated
| @@ -0,0 +1,188 @@ | |||
| # Copyright 2022 Neal Chambers | |||
| @@ -60,7 +60,8 @@ Another unique advantage of RP2 is [transparent computation](https://github.com/ | |||
| RP2 currently supports the following accounting methods: | |||
| * US: [FIFO](https://www.investopedia.com/terms/f/fifo.asp), [LIFO](https://www.investopedia.com/terms/l/lifo.asp) and [HIFO](https://www.investopedia.com/terms/h/hifo.asp). Note that these methods use universal application (not per-wallet application), as explained [here](https://www.forbes.com/sites/shehanchandrasekera/2020/09/17/what-crypto-taxpayers-need-to-know-about-fifo-lifo-hifo-specific-id/); | |||
| * Spain: FIFO; | |||
| * Japan: Total Average Method. | |||
| * Japan: Total Average Method; | |||
| * Ireland: FIFO. In Ireland specific rules apply to assets bought and sold within a 4 week window. See [here](https://www.revenue.ie/en/tax-professionals/tdm/income-tax-capital-gains-tax-corporation-tax/part-19/19-04-03.pdf) and [here](https://www.revenue.ie/en/gains-gifts-and-inheritance/transfering-an-asset/selling-or-disposing-of-shares.aspx). Note that this is **NOT** catered for. | |||
There was a problem hiding this comment.
Interesting: perhaps this could be handled (in a separate PR) with a new Ireland-specific accounting method plugin, a variation of FIFO that treats specially lot fractions that are sold within 4 weeks of the last purchase.
|
Great, thanks! |
Thank you for the good work! |
No description provided.