fix(rpc): use from_block and to_block in event filter #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0.1.0 of the JSON-RPC specification requires `from_block` and `to_block` in the event filter object. We somehow failed to make this change in pathfinder and were using the old `fromBlock` and `toBlock` names. This change keeps the old names as aliases so that we don't break the API for users who have updated their code to account for the bug. Fixes #536.
koivunej
approved these changes
Aug 29, 2022
Mirko-von-Leipzig
approved these changes
Aug 29, 2022
CHr15F0x
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.1.0 of the JSON-RPC specification requires
from_blockandto_blockin the event filter object. We somehow failed to makethis change in pathfinder and were using the old
fromBlockand
toBlocknames.This change keeps the old names as aliases so that we don't break the
API for users who have updated their code to account for the bug.
Fixes #536.