Skip to content

Commit

Permalink
Fix macOS CI builds Qt5 package name change
Browse files Browse the repository at this point in the history
Brew has renamed qt5 to qt@5.

Avoid breaking cmake's Qt5 modules by replacing the "brew link qt5" step with a custom PATH on macOS.
  • Loading branch information
davvid authored Feb 29, 2024
1 parent e04081c commit c05eee8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@ jobs:
run: |
brew install neovim
brew ls --formula | grep -wq ninja || brew install ninja
brew ls --formula | grep -wq qt5 || brew install qt5
brew ls --formula | grep -wq qt5 || brew install qt@5
brew ls --formula | grep -wq msgpack || brew install msgpack
brew link qt5 --force
#
# Build and Test
Expand All @@ -83,6 +82,7 @@ jobs:
CMAKE_BUILD_TYPE: ${{ matrix.flavor }}
CMAKE_GENERATOR: ${{ matrix.generator }}
run: >
env PATH=${{ startsWith(matrix.runner, 'macos') && '/usr/local/opt/qt@5/bin:' || '' }}/usr/local/bin:/usr/bin/:/bin
cmake -B ./build
-DCMAKE_INSTALL_PREFIX=${{ github.workspace }}/install
-DCMAKE_C_COMPILER=${{ matrix.cc }}
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
- name: MacOS - Publish
if: ${{ matrix.publish && startsWith(matrix.runner, 'macos') }}
run: |
macdeployqt ./build/bin/nvim-qt.app -dmg
/usr/local/opt/qt@5/bin/macdeployqt ./build/bin/nvim-qt.app -dmg
mv ./build/bin/nvim-qt.dmg neovim-qt.dmg
- name: Upload Artifacts
Expand Down

0 comments on commit c05eee8

Please sign in to comment.