Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: store window geometry in ~/.config/nvim-qt/window_geometry.conf #1094

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

davvid
Copy link
Contributor

@davvid davvid commented Feb 6, 2024

The single-argument QSettings constructor sets the organization name. nvim-qt is passing "window-geometry" as the organization name, which results in QSettings using ~/.config/window-geometry.conf. This is undesirable because the file is written to the root of ~/.config without any indication about which application created or uses the file.

Set the organization name to "nvim-qt" when writing window geometry so that ~/.config/nvim-qt/window-geometry.conf is used instead.

…conf

The single-argument QSettings constructor sets the organization name.
nvim-qt is passing "window-geometry" as the organization name, which
results in QSettings using `~/.config/window-geometry.conf`.
This is undesirable because the file is written to the root of
`~/.config` without any indication about which application created
or uses the file.

Set the organization name to "nvim-qt" when writing window geometry
so that `~/.config/nvim-qt/window-geometry.conf` is used instead.
@equalsraf equalsraf merged commit 31ddd19 into equalsraf:master Feb 6, 2024
16 of 17 checks passed
@equalsraf
Copy link
Owner

Merged, thanks @davvid

davvid added a commit to davvid/neovim-qt that referenced this pull request Feb 11, 2024
Avoid restoring window geometry when `restore_window_geometry=false`
in `~/.config/nvim-qt/window-geometry.conf`. Defaults to `true`.

Suggested-by: @damanis on github
Related-to: equalsraf#997
Related-to: equalsraf#1094
davvid added a commit to davvid/neovim-qt that referenced this pull request Mar 2, 2024
Do not save or restore window geometry when `restore_window_geometry=false`
in `~/.config/nvim-qt/window-geometry.conf`. Defaults to `true`.

Suggested-by: @damanis on github
Related-to: equalsraf#997
Related-to: equalsraf#1094
jgehrig pushed a commit that referenced this pull request Mar 3, 2024
Do not save or restore window geometry when `restore_window_geometry=false`
in `~/.config/nvim-qt/window-geometry.conf`. Defaults to `true`.

Suggested-by: @damanis on github
Related-to: #997
Related-to: #1094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants