Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRH Cloud event update #14

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

CRH Cloud event update #14

wants to merge 9 commits into from

Conversation

timmy-equinix
Copy link

@timmy-equinix timmy-equinix commented Dec 18, 2024 •
edited by thogarty
Loading

Checklist

  • I have read the CONTRIBUTING.md
  • I certify that my preview and released lists for Events/Metrics/Alerts are correct
  • I certify that all Events/Metrics/Alerts in released are properly tested and ready for production

CRH Observability event schema

@timmy-equinix timmy-equinix requested review from ryli17 and thogarty and removed request for ryli17 December 18, 2024 17:11
@ryli17 ryli17 requested a review from anchala71 December 18, 2024 17:59
ryli17
ryli17 requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ryli17 ryli17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This json is intend to define data object in the cloudevent. Thus it is used in dataschema in cloudevent. It is not to define the cloudevent metadata. Please refer to other files in fabric domain.

@timmy-equinix timmy-equinix requested a review from a team as a code owner January 8, 2025 00:42
@github-actions github-actions bot requested a review from a team as a code owner January 8, 2025 00:42
@timmy-equinix
CRH Cloud event update
e7e3e1c
@timmy-equinix
Merge remote-tracking branch 'origin/crh_cloudevent_schema_update' in…
5be5ab8 
…to crh_cloudevent_schema_update

# Conflicts:
#	jsonschema/catalog.json
@ryli17
Copy link
Contributor

ryli17 commented Jan 15, 2025

  1. Please rebase to main brunch
  2. Please don't change catalog.json, DataLoader.json, and README.md. They will be generated automatically.
  3. Please make sure github actions pass validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thogarty thogarty thogarty requested changes

@ryli17 ryli17 ryli17 requested changes

@anchala71 anchala71 Awaiting requested review from anchala71

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timmy-equinix @ryli17 @thogarty