-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use both project and user API token and populate default org id and projectid #325
feat: use both project and user API token and populate default org id and projectid #325
Conversation
9d34643
to
1d3e930
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to run much slower now than the current release. I assume that's due to it doing much more searching?
1d3e930
to
f97ca14
Compare
f97ca14
to
15baacd
Compare
15baacd
to
13e7ebb
Compare
So just tested this out, it's nearly 0 delay while waiting for it get your project id and org on the current main branch, and about 3-4 seconds on this new version. If we're ok with that, we are good to go. |
13e7ebb
to
dee80c1
Compare
dee80c1
to
55cbc0a
Compare
exclude := []string{"devices", "members", "memberships", "invitations", "ssh_keys", "volumes", "backend_transfer_enabled", "updated_at", "customdata", "event_alert_configuration", | ||
"timezone", "features", "avatar_url", "avatar_thumb_url", "two_factor_auth", "mailing_address", "max_projects", "verification_stage", "emails", "phone_number", "restricted", | ||
"full_name", "email", "social_accounts", "opt_in_updated_at", "opt_in", "first_name", "last_name", "last_login_at"} | ||
user, _, err := c.UserService.FindCurrentUser(context.Background()).Include(include).Exclude(exclude).Execute() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should stick with loading the current user first so that, if we were given a user token, we avoid loading more projects than necessary or making multiple paginated calls to the projects endpoint. What is the response and/or error that comes back if we try to run c.UserService.FindCurrentUser(context.Background()).Include(include).Exclude(exclude).Execute()
with a project token? Is there something in the response/error that we can use to decide that the token might be a project token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of #265 had an approach in mind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is already largely following the steps in the issue description. I still prefer adding project API support in a way that does not add latency to user token initialization, but adding the 2-project limit described in that issue to this PR would at least reduce the added latency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris pointed out that a user might only have 1 project, in which case metal init
would treat their token as a project token instead of a user token; the token type doesn't have any impact outside of the init command, though, so which endpoint we try to load first is largely a philosophical issue. I leave the decision up to the contributor as to whether we should remove auto-pagination from getProjectsOK
or load the current user endpoint first and then try projects if current user 403s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a nitpick about the output which seems to be more of a debugging aid rather than necessary or helpful to end-users. https://github.com/equinix/metal-cli/pull/325/files#r1471550998
If this text were accompanied by a full list of organization ids that the key could access, it may be more useful. I would want to defer that work to accompany investigation into TUI or more interactive prompting tools (with name based autocompletes or console drop downs, for example).
Otherwise, this has been tested for a User API Key and Project API key. In my User testing I had a null project id default for some tests and a defined id - worked fine under both conditions.
…and project id accordingly
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
ad90da8
to
d8f3e05
Compare
#265