-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXF-98497: Fix failing GHA Docs #112
Conversation
Tested these changes. GHA jobs are passing here |
git-push: "false" | ||
run: | | ||
find examples -type d -mindepth 1 -maxdepth 1 | while read dir; do | ||
terraform-docs -c "./templates/examples-terraform-docs.yaml" --output-file "README.md" "$dir" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thogarty I couldn't find a corresponding attribute (in GHA) to support the last parameter in terraform docs command( "$dir" ) which defines inside which directory the terraform-docs command would run. Therefore, I decided to use this approach of using running a script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support the approach. Still leverages terraform-docs just not directly with their GHA job.
I was wondering why a pull request wasn't created at the the end of the github action that was run from your change? https://github.com/equinix/terraform-equinix-fabric/actions/runs/10322345359/job/28577358771
In the action you ran it should create a PR with the updates that it made during the earlier steps of the GHA workflow job.
2004e42
to
e26343d
Compare
c054020
to
f132563
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @d-bhola !
Modified GHA jobs by adding scripts for running terraform-docs. My changes include four jobs-
Minor changes to examples-terraform-docs.yaml config file