CXF-83184: Adding NIMF Metal-2-AWS Example #34

srushti-patl · 2024-02-15T21:58:02Z

Includes:
Metal-2-AWS Example

iawells

varaibles.tf -> variables.tf

iawells · 2024-02-23T00:11:02Z

examples/NIMF-Metal-2-AWS-connection/terraform.tfvars.example

+purchase_order_number       = "1-323292"
+project_id                  = "<Project_ID>"
+aside_ap_authentication_key = "<Metal_Auth_Token>"
+aside_ap_type               = "METAL_NETWORK"


If this is a metal network example, why is this an input that can be modified?

We have added this example based on the Fabric Connection contract. We've included it as an input variable for testing purposes. Once the feature is ready for production(supported from Metal side as well), we will update it accordingly

We should update this. The module has the variable as well but it will always be the same Access Point type for Metal Connection module, right?

Signed-off-by: GitHub <[email protected]> Co-authored-by: thogarty <[email protected]>

…rtual interface connections (#39) * fix:Replacing aws_vpn_gateway with aws_dx_gateway resource * chore: Removing extra space * chore: fixing indentation * chore: Adding trailing line

* feat: Integrating GCP Provider with Fabric examples * chore:Adding variable type and fixing indentation * fix: Changing variables name from gcp to google * misc:removing files for old GCP example

* feat: Adding z_side block for virtual device & FCR 2 VD example * feat: Adding FCR 2 VD redundant example * nit: Adding indentation space and changing variables names * misc: Updating variables for FCR 2 NE Redundant connection & adding content readme.md file * nit: Removing extra line from REDME.md file. * misc: Adding output id for secondary connection and changing variable name for DOT1Q vlan_tag * chore: Fixing format * chore: Updating README.md file * fix: Adding secondary VD variables in modules main.tf file

Signed-off-by: GitHub <[email protected]> Co-authored-by: srushti-patl <[email protected]>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: Updating aws_dx_gateway resource & changing ibm2 example variable name for additional_info * fix: Updating aws_dx_gateway resource & changing ibm2 example variable name for additional_info

* Update docs for v0.4.0 release * Include bug fix doc updates

Signed-off-by: GitHub <[email protected]> Co-authored-by: srushti-patl <[email protected]>

* feat: Adding GHA workflow for Terra tests * feat: Adding new terratests for port-2port connection and updating variables * misc: removing cloud router changes from the PR * misc: fixing UAT terra-tests workflow * misc: Adding versions file to uat/tests examples * fix: Updating UAT tests workflow and moving terra tests under one file * fix: Appending Secret values directly to the file in UAT workflow * fix: fixing setup variables files job in UAT workflow * fix: deleting old terra tests files * nit: fixing indentation * misc:Updating workflow file * misc:reverting the latest change in UAT workflow * misc:Updating UAT workflow file and variable files * fix: Updating variables files for examples * fix: Adding project_id block in connection modules & examples * fix: Adding project_id varaible in IBM2 example

…th AWS provider

thogarty

Changes requested.

thogarty · 2024-03-28T22:14:28Z

examples/NIMF-Metal-2-AWS-connection/README.md

+# Metal to AWS Connection Example
+
+This example shows how to leverage the [Metal Connection Module](../../modules/metalconnection/README.md)
+to create a Fabric Connection from a Metal to AWS.


Should be "to create a Fabric Connection from Equinix Metal to AWS"

thogarty · 2024-03-28T22:15:28Z

examples/NIMF-Metal-2-AWS-connection/terraform.tfvars.example

+purchase_order_number       = "1-323292"
+project_id                  = "<Project_ID>"
+aside_ap_authentication_key = "<Metal_Auth_Token>"
+aside_ap_type               = "METAL_NETWORK"


We should update this. The module has the variable as well but it will always be the same Access Point type for Metal Connection module, right?

thogarty · 2024-03-28T22:16:27Z

examples/NIMF-Metal-2-AWS-connection/versions.tf

+  required_providers {
+    equinix = {
+      source  = "equinix/equinix"
+      version = ">= 1.20.0"


We shouldn't add new content with old versions of the Terraform provider. This will need to be updated to be the latest version of the release after https://github.com/equinix/terraform-provider-equinix/pull/626/files#diff-703d45b76399eb49451408ebb9688abdad1236c9cfb95664c5044fe2488e19fb is merged into the provider.

thogarty · 2024-03-28T22:17:02Z

modules/metal-connection/README.md

+Please refer to the metal-* examples in this module's registry for more details on how to leverage the submodule.
+
+<!-- Begin Module Docs (Do not edit contents) -->
+## Equinix Fabric Developer Documentation


You don't need any content between these boundaries. It will be overwritten anyway.

thogarty · 2024-03-28T22:17:31Z

modules/metal-connection/main.tf

+  }
+  a_side {
+    access_point {
+      type               = var.aside_ap_type


If this is truly a module for Metal then the Access Point will always be the same, right?

thogarty · 2024-03-28T22:18:21Z

modules/metal-connection/variables.tf

+  type        = string
+  default     = ""
+}
+variable "additional_info" {


It should be marked sensitive here as well. We never know what will go in the additional info so we should prevent it from being exposed.

thogarty · 2024-03-28T22:18:39Z

modules/metal-connection/versions.tf

+  required_providers {
+    equinix = {
+      source  = "equinix/equinix"
+      version = ">= 1.20.0"


This needs to be updated with the latest version of the TF provider after the merge of this PR: https://github.com/equinix/terraform-provider-equinix/pull/626/files#diff-703d45b76399eb49451408ebb9688abdad1236c9cfb95664c5044fe2488e19fb

thogarty · 2024-03-28T22:20:42Z

examples/NIMF-Metal-2-AWS-connection/README.md

@@ -0,0 +1,13 @@
+# Metal to AWS Connection Example


The name of this directory doesn't follow our example naming patterns. Should be all lowercase, kebab case (which it is) and the module should be the prefix. Rename directory to metal-nimf-2-aws-connection/

…th AWS provider

srushti-patl and others added 2 commits February 15, 2024 13:56

CXF-83184: Adding NIMF Metal-2-AWS Example

ef3bf3f

Fix: fixing Vd-2-Azure example script (#35)

966f0a5

iawells suggested changes Feb 23, 2024

View reviewed changes

iawells reviewed Feb 23, 2024

View reviewed changes

srushti-patl and others added 15 commits February 22, 2024 16:25

chore: Updating variables.tf file name

6a84aeb

generate-terraform-docs: automated action (#36)

287758f

Signed-off-by: GitHub <[email protected]> Co-authored-by: thogarty <[email protected]>

CXF-89291: Replacing aws_vpn_gateway with aws_dx_gateway for their vi…

6bb6e04

…rtual interface connections (#39) * fix:Replacing aws_vpn_gateway with aws_dx_gateway resource * chore: Removing extra space * chore: fixing indentation * chore: Adding trailing line

feat: Integrating GCP Provider with Fabric examples (#37)

29720d6

* feat: Integrating GCP Provider with Fabric examples * chore:Adding variable type and fixing indentation * fix: Changing variables name from gcp to google * misc:removing files for old GCP example

generate-terraform-docs: automated action (#45)

2b6decc

Signed-off-by: GitHub <[email protected]> Co-authored-by: srushti-patl <[email protected]>

Update peter-evans/create-pull-request action to v6 (#33)

7d9ebfd

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: Updating aws_dx_gateway resource & changing ibm2 variable (#47)

5b398cc

* fix: Updating aws_dx_gateway resource & changing ibm2 example variable name for additional_info * fix: Updating aws_dx_gateway resource & changing ibm2 example variable name for additional_info

Update docs for v0.4.0 release (#46)

f88547d

* Update docs for v0.4.0 release * Include bug fix doc updates

generate-terraform-docs: automated action (#48)

2e71cca

Signed-off-by: GitHub <[email protected]> Co-authored-by: srushti-patl <[email protected]>

feat: Adding metal provider examples for NIMF functionality

97f2713

feat: Adding metal-connection sub-module and updating NIMF example wi…

94ee636

…th AWS provider

misc:Marking secrets variable as sensitive

2cf9ed9

misc:removing duplicate aws connection output

2c0f584

thogarty requested changes Mar 28, 2024

View reviewed changes

srushti-patl added 10 commits March 29, 2024 13:12

fix: Removing aside_ap_type variable and updating readme.md file

76f0b80

feat: Adding GHA workflow and Terratest for METAL-NIMF-2-AWS connection

c753a64

CXF-83184: Adding NIMF Metal-2-AWS Example

1746cae

chore: Updating variables.tf file name

fda4bb7

feat: Adding metal provider examples for NIMF functionality

e337262

feat: Adding metal-connection sub-module and updating NIMF example wi…

bb4e806

…th AWS provider

misc:Marking secrets variable as sensitive

b048ca7

misc:removing duplicate aws connection output

b52ce17

fix: Removing aside_ap_type variable and updating readme.md file

d98e3b6

feat: Adding GHA workflow and Terratest for METAL-NIMF-2-AWS connection

7e2da67

srushti-patl added 2 commits April 2, 2024 13:08

Merge remote-tracking branch 'origin/CXF-84871' into CXF-84871

538226a

fix: Refactoring NIMF terratests tp metal-nimf folder

4a9f5ed

srushti-patl marked this pull request as draft April 2, 2024 21:06

srushti-patl closed this Apr 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CXF-83184: Adding NIMF Metal-2-AWS Example #34

CXF-83184: Adding NIMF Metal-2-AWS Example #34

srushti-patl commented Feb 15, 2024

iawells left a comment •

edited

Loading

iawells Feb 23, 2024

srushti-patl Feb 23, 2024

thogarty Mar 28, 2024

thogarty left a comment

thogarty Mar 28, 2024

thogarty Mar 28, 2024

thogarty Mar 28, 2024

thogarty Mar 28, 2024

thogarty Mar 28, 2024

thogarty Mar 28, 2024

thogarty Mar 28, 2024

thogarty Mar 28, 2024

CXF-83184: Adding NIMF Metal-2-AWS Example #34

CXF-83184: Adding NIMF Metal-2-AWS Example #34

Conversation

srushti-patl commented Feb 15, 2024

iawells left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thogarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iawells left a comment •

edited

Loading