CXF 88608: UAT Terratest workflow for Cloud Router Connectivity #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
srushti-patl
commented
Mar 15, 2024
•
srushti-patl
commented
- Added terra tests for cloud router and routing protocol connectivity
- Added following examples to tests/uat folder:
- FCR 2 AWS
- FCR 2 Azure
- FCR 2 Port Routing Protocol
- Updated Virtual Device Module with removing aside_port_tag logic
…rotocol connectivity
thogarty
approved these changes
Apr 4, 2024
| @@ -1,22 +1,77 @@ | |||
| name: terratests-uat-suite | |||
| name: terratests-examples-without-external-providers-suite | |||
There was a problem hiding this comment.
terratests-uat-suite was the correct name here.
| @@ -46,7 +46,7 @@ variable "aside_fcr_uuid" { | |||
| variable "zside_ap_authentication_key" { | |||
| description = "Authentication key for provider based connections" | |||
| type = string | |||
| sensitive = true | |||
There was a problem hiding this comment.
This should still be sensitive = true. No default should be here because it's required.
| @@ -0,0 +1,9 @@ | |||
| terraform { | |||
There was a problem hiding this comment.
File should just be removed completely.
| @@ -0,0 +1,81 @@ | |||
| variable "equinix_client_id" { | |||
There was a problem hiding this comment.
File should just be removed completely.
| run: | ||
| go test ./tests/uat -v -coverprofile coverage_uat_modules.txt -covermode=atomic -count 1 -parallel 8 -run "(PNFV)" -timeout 180m | ||
|
|
||
| - name: Setup Node.js 20.11.1 |
There was a problem hiding this comment.
Can be removed. Not doing anything.
| - name: Run Go Tests | ||
| run: | ||
| go test ./tests/uat -v -coverprofile coverage_uat_modules.txt -covermode=atomic -count 1 -parallel 8 -timeout 180m | ||
| go test ./tests/uat -v -coverprofile coverage_uat_modules.txt -covermode=atomic -count 1 -parallel 8 -run "(PFCR)" -timeout 180m | ||
|
|
||
| - name: Setup Node.js 20.11.1 |
There was a problem hiding this comment.
Can be removed. Step not doing anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.