Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include kubeconfig filename in outputs, make content sensitive #94

Merged
merged 9 commits into from
Dec 9, 2021
Merged

include kubeconfig filename in outputs, make content sensitive #94

merged 9 commits into from
Dec 9, 2021

Conversation

displague
Copy link
Member

Following #93, this PR adds the kubeconfig_filename to the outputs.
The kubeconfig variable is reduced from a structure to the file contents, which are marked sensitive.

@displague
Copy link
Member Author

cc @keithmattix

@displague
Copy link
Member Author

Also attempts to perform/fix a full CI build

@keithmattix
Copy link
Contributor

@displague The CI build seems to fail because of a missing private key during the key transfer? Weird race condition maybe?

@displague displague merged commit f489a57 into main Dec 9, 2021
@displague displague deleted the kubeconfigfile-output branch December 9, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithmattix keithmattix keithmattix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@displague @keithmattix