Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename SegmentCreationMethod to Method #13

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

MegaAnda123
Copy link
Collaborator

@MegaAnda123 MegaAnda123 commented Apr 24, 2024

Description

Change enum SegmentCreationMethod to Method.

Why

Better name.

How

Refactor rename enum.

Close: #5

Checklist:

Before submitting this PR, please make sure:

  • I am complying with the contributing doc
  • My code builds clean without any errors or warnings
  • I have added/extended tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation, and it builds correctly

@MegaAnda123 MegaAnda123 self-assigned this Apr 24, 2024
Copy link
Collaborator

@Aleksander-Karlsson Aleksander-Karlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aleksander-Karlsson Aleksander-Karlsson merged commit fb592cb into main Apr 26, 2024
11 checks passed
@Aleksander-Karlsson Aleksander-Karlsson deleted the refactor/rename-enum branch April 26, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename SEGMENTLENGTH to METHOD
2 participants