refactor: extract Sidebar and Tabs out into their own plugins (#585)

* refactor: extract Sidebar and Tabs out into their own plugins * refactor: remove unused
equinor · Oct 6, 2023 · 27cf130 · 27cf130
1 parent 2051afb
commit 27cf130
Show file tree

Hide file tree

Showing 37 changed files with 205 additions and 137 deletions.
diff --git a/example/app/data/DemoDataSource/apps/MySignalApp/instances/CaseUISelector.recipe.json b/example/app/data/DemoDataSource/apps/MySignalApp/instances/CaseUISelector.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "UiRecipesSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "items": [
@@ -38,11 +38,10 @@
     {
       "name": "Tabs",
       "type": "CORE:UiRecipe",
-      "plugin": "@development-framework/dm-core-plugins/view_selector",
+      "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
       "config": {
         "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
-        "childTabsOnRender": true,
-        "asSidebar": false
+        "childTabsOnRender": true
       }
     },
     {

diff --git a/example/app/data/DemoDataSource/recipes/apps/EmployeeApp/employeeApp.recipe.json b/example/app/data/DemoDataSource/recipes/apps/EmployeeApp/employeeApp.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "UiRecipesSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "items": [

diff --git a/example/app/data/DemoDataSource/recipes/apps/signal_app/recipe_links/appDefault.recipe.json b/example/app/data/DemoDataSource/recipes/apps/signal_app/recipe_links/appDefault.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "Tabs",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
-      "childTabsOnRender": true,
-      "asSidebar": false
+      "childTabsOnRender": true
     }
   },
   "uiRecipes": [

diff --git a/...ataSource/recipes/apps/signal_app/recipe_links/containers/equallySpacedSignal.recipe.json b/...ataSource/recipes/apps/signal_app/recipe_links/containers/equallySpacedSignal.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "UiRecipesSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "items": [

diff --git a/example/app/data/DemoDataSource/recipes/apps/signal_app/recipe_links/signalApp.recipe.json b/example/app/data/DemoDataSource/recipes/apps/signal_app/recipe_links/signalApp.recipe.json
@@ -30,11 +30,10 @@
     {
       "name": "View study",
       "type": "CORE:UiRecipe",
-      "plugin": "@development-framework/dm-core-plugins/view_selector",
+      "plugin": "@development-framework/dm-core-plugins/view_selector/sidebar",
       "config": {
         "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
         "childTabsOnRender": true,
-        "asSidebar": true,
         "items": [
           {
             "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/.../data/DemoDataSource/recipes/apps/signal_app/recipe_links/signals_simple/case.recipe.json b/.../data/DemoDataSource/recipes/apps/signal_app/recipe_links/signals_simple/case.recipe.json
@@ -64,11 +64,10 @@
     {
       "name": "Tabs",
       "type": "CORE:UiRecipe",
-      "plugin": "@development-framework/dm-core-plugins/view_selector",
+      "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
       "config": {
         "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
         "childTabsOnRender": true,
-        "asSidebar": false,
         "items": [
           {
             "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/...data/DemoDataSource/recipes/apps/signal_app/recipe_links/signals_simple/study.recipe.json b/...data/DemoDataSource/recipes/apps/signal_app/recipe_links/signals_simple/study.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "Tabs",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/...ta/DemoDataSource/recipes/apps/signal_app/recipe_links/signals_simple/studyNC.recipe.json b/...ta/DemoDataSource/recipes/apps/signal_app/recipe_links/signals_simple/studyNC.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "Tabs",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
-      "childTabsOnRender": true,
-      "asSidebar": false
+      "childTabsOnRender": true
     }
   },
   "uiRecipes": [

diff --git a/example/app/data/DemoDataSource/recipes/blueprint.recipe.json b/example/app/data/DemoDataSource/recipes/blueprint.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "UiRecipesSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/sidebar",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": true,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/example/app/data/DemoDataSource/recipes/file.recipe.json b/example/app/data/DemoDataSource/recipes/file.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "UiRecipesSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "items": [

diff --git a/example/app/data/DemoDataSource/recipes/plugins/form/nested/carRentalCompany.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/form/nested/carRentalCompany.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/example/app/data/DemoDataSource/recipes/plugins/form/nested/person.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/form/nested/person.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/example/app/data/DemoDataSource/recipes/plugins/form/read_only/carRentalCompany.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/form/read_only/carRentalCompany.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/example/app/data/DemoDataSource/recipes/plugins/form/read_only/person.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/form/read_only/person.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/...a/DemoDataSource/recipes/plugins/form/read_only_primitives/readOnlyPrimitives.recipe.json b/...a/DemoDataSource/recipes/plugins/form/read_only_primitives/readOnlyPrimitives.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/example/app/data/DemoDataSource/recipes/plugins/form/simple/simple.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/form/simple/simple.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/example/app/data/DemoDataSource/recipes/plugins/form/uncontained/company.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/form/uncontained/company.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/example/app/data/DemoDataSource/recipes/plugins/form/uncontained/person.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/form/uncontained/person.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/example/app/data/DemoDataSource/recipes/plugins/grid/example/nested.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/grid/example/nested.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {}
   },
   "uiRecipes": [

diff --git a/example/app/data/DemoDataSource/recipes/plugins/grid/example/order.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/grid/example/order.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true

diff --git a/example/app/data/DemoDataSource/recipes/plugins/grid/example/orderItem.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/grid/example/orderItem.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "UiRecipesSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "items": [

diff --git a/example/app/data/DemoDataSource/recipes/plugins/list/order_example/order.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/list/order_example/order.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true

diff --git a/example/app/data/DemoDataSource/recipes/plugins/list/order_example/orderItem.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/list/order_example/orderItem.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "UiRecipesSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "items": [

diff --git a/example/app/data/DemoDataSource/recipes/plugins/list/task_list/task.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/list/task_list/task.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "UiRecipesSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "items": [

diff --git a/example/app/data/DemoDataSource/recipes/plugins/list/task_list/taskList.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/list/task_list/taskList.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true

diff --git a/example/app/data/DemoDataSource/recipes/plugins/table/car_list/carList.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/table/car_list/carList.recipe.json
@@ -4,7 +4,7 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "items": [

diff --git a/example/app/data/DemoDataSource/recipes/plugins/view_selector/car_infosys/car.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/view_selector/car_infosys/car.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/...e/app/data/DemoDataSource/recipes/plugins/view_selector/car_infosys/carGarage.recipe.json b/...e/app/data/DemoDataSource/recipes/plugins/view_selector/car_infosys/carGarage.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/sidebar",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": true,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/example/app/data/DemoDataSource/recipes/plugins/view_selector/car_infosys/owner.recipe.json b/example/app/data/DemoDataSource/recipes/plugins/view_selector/car_infosys/owner.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/...e/app/data/DemoDataSource/recipes/plugins/view_selector/car_infosys/technical.recipe.json b/...e/app/data/DemoDataSource/recipes/plugins/view_selector/car_infosys/technical.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/...data/DemoDataSource/recipes/plugins/view_selector/roles_school_example/school.recipe.json b/...data/DemoDataSource/recipes/plugins/view_selector/roles_school_example/school.recipe.json
@@ -4,11 +4,10 @@
   "initialUiRecipe": {
     "name": "ViewSelector",
     "type": "CORE:UiRecipe",
-    "plugin": "@development-framework/dm-core-plugins/view_selector",
+    "plugin": "@development-framework/dm-core-plugins/view_selector/tabs",
     "config": {
       "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
       "childTabsOnRender": true,
-      "asSidebar": false,
       "items": [
         {
           "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",

diff --git a/...oDataSource/recipes/plugins/view_selector/roles_school_example/schoolDistrict.recipe.json b/...oDataSource/recipes/plugins/view_selector/roles_school_example/schoolDistrict.recipe.json
@@ -30,11 +30,10 @@
     {
       "name": "AdminViewSelector",
       "type": "CORE:UiRecipe",
-      "plugin": "@development-framework/dm-core-plugins/view_selector",
+      "plugin": "@development-framework/dm-core-plugins/view_selector/sidebar",
       "config": {
         "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
         "childTabsOnRender": true,
-        "asSidebar": true,
         "items": [
           {
             "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",
@@ -62,11 +61,10 @@
     {
       "name": "OperatorViewSelector",
       "type": "CORE:UiRecipe",
-      "plugin": "@development-framework/dm-core-plugins/view_selector",
+      "plugin": "@development-framework/dm-core-plugins/view_selector/sidebar",
       "config": {
         "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorConfig",
         "childTabsOnRender": true,
-        "asSidebar": true,
         "items": [
           {
             "type": "PLUGINS:dm-core-plugins/view_selector/ViewSelectorItem",