-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stack plugin #1276
Merged
Merged
feat: stack plugin #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awesthouse
force-pushed
the
feat/stack-plugin
branch
from
February 7, 2024 11:58
cf793e2
to
7fdc8a0
Compare
pbullhove
suggested changes
Feb 7, 2024
packages/dm-core-plugins/blueprints/stack/StackPluginConfig.json
Outdated
Show resolved
Hide resolved
packages/dm-core-plugins/blueprints/stack/StackPluginConfig.json
Outdated
Show resolved
Hide resolved
awesthouse
force-pushed
the
feat/stack-plugin
branch
from
February 8, 2024 09:27
952d853
to
eb129ac
Compare
pbullhove
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/dm-core-plugins/blueprints/stack/StackPluginConfig.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
Add StackPlugin to dm-core-plugins. Allows user to stack views on top or next to each other.
In items array, just pass viewConfig objects
Example of config:
Open to discussing naming. "MultiView" to me seems like you can switch between multiple views of the same content. "Flexbox" is more css language. If we describe this as user being able to stack views on top of or next to each other - I feel like it's pretty self-explanatory.
Why is this pull request needed?
Help with some layout use-cases that are a bit over-complicated.
Issues related to this change
#1258