Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stack plugin #1276

Merged
merged 7 commits into from
Feb 8, 2024
Merged

feat: stack plugin #1276

merged 7 commits into from
Feb 8, 2024

Conversation

awesthouse
Copy link
Contributor

@awesthouse awesthouse commented Feb 7, 2024

What does this pull request change?

Add StackPlugin to dm-core-plugins. Allows user to stack views on top or next to each other.
In items array, just pass viewConfig objects

Example of config:

{
      "name": "Dashboard",
      "type": "CORE:UiRecipe",
      "description": "ESS Plot",
      "plugin": "@development-framework/dm-core-plugins/stack",
      "config": {
        "type": "PLUGINS:dm-core-plugins/stack/StackPluginConfig",
        "items": [
          {
            "type": "CORE:ReferenceViewConfig",
            "scope": "sce",
            "recipe": "Date"
          },
          {
            "type": "CORE:ReferenceViewConfig",
            "scope": "job",
            "recipe": "Fetch_Signals_OmniaTS"
          },
          {
            "type": "CORE:ReferenceViewConfig",
            "scope": "sce.signals",
            "recipe": "List"
          }
        ]
      }
    },

Open to discussing naming. "MultiView" to me seems like you can switch between multiple views of the same content. "Flexbox" is more css language. If we describe this as user being able to stack views on top of or next to each other - I feel like it's pretty self-explanatory.

Why is this pull request needed?

Help with some layout use-cases that are a bit over-complicated.

Issues related to this change

#1258

@awesthouse awesthouse requested a review from a team as a code owner February 7, 2024 11:57
@awesthouse awesthouse requested a review from pbullhove February 8, 2024 09:38
Copy link
Contributor

@pbullhove pbullhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awesthouse awesthouse merged commit 2ae3a03 into main Feb 8, 2024
8 checks passed
@awesthouse awesthouse deleted the feat/stack-plugin branch February 8, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants