Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sidebar navigate trigger reload #1378

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

soofstad
Copy link
Collaborator

@soofstad soofstad commented Mar 11, 2024

What does this pull request change?

  • Sidebar plugin now refreshes the content when navigating

Why is this pull request needed?

  • Navigating using the "Sidebar"-plugin should refresh "sub-pages", and not show outdated content.

Issues related to this change

fixes #1374 (NOTE: Not implemented an optimistic load. Feel like that is a bigger task that should be added on a more fundamental level)

@soofstad soofstad self-assigned this Mar 11, 2024
@soofstad soofstad requested a review from a team as a code owner March 11, 2024 08:33
@soofstad soofstad force-pushed the fix/sidebar-navigate-trigger-reload branch 3 times, most recently from 016836b to 709f89b Compare March 12, 2024 08:05
@soofstad soofstad force-pushed the fix/sidebar-navigate-trigger-reload branch from 709f89b to 10fe8fd Compare March 12, 2024 08:09
@soofstad soofstad force-pushed the fix/sidebar-navigate-trigger-reload branch from 10fe8fd to b8f35d0 Compare March 13, 2024 13:54
@soofstad soofstad merged commit fc6f684 into main Mar 13, 2024
8 checks passed
@soofstad soofstad deleted the fix/sidebar-navigate-trigger-reload branch March 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar select item should remount / update items
2 participants