Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/form-cleanup #1379

Merged
merged 9 commits into from
Mar 11, 2024
Merged

Refactor/form-cleanup #1379

merged 9 commits into from
Mar 11, 2024

Conversation

awesthouse
Copy link
Contributor

@awesthouse awesthouse commented Mar 11, 2024 •
edited
Loading

What does this pull request change?

Form cleanup

  • A lot of components get their own folder and components only used in that component are moved from "general" folders to where they are used
  • Remove some unnecessary mapping and and spread operators
  • Utilities cleanup
  • Split FormTemplate/ComplextAttributeTemplate so that it keeps 1 component per file

Renaming

  • FormTemplate -> ComplexAttributeTemplate
  • AttributeField -> AttributeFieldSelector

Why is this pull request needed?

Just some cleanup 🙂

@awesthouse awesthouse requested a review from a team as a code owner March 11, 2024 09:03
pbullhove
pbullhove approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@pbullhove pbullhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.
I agree on the name changes, i think they are fine.

@awesthouse awesthouse merged commit 6f48b21 into main Mar 11, 2024
8 checks passed
@awesthouse awesthouse deleted the refactor/form branch March 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbullhove pbullhove pbullhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awesthouse @pbullhove