Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/job control styling improvements #1380

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

pbullhove
Copy link
Contributor

@pbullhove pbullhove commented Mar 11, 2024

What does this pull request change?

Looks better.

image image image

Why is this pull request needed?

Was ugly.

Issues related to this change

@pbullhove pbullhove linked an issue Mar 11, 2024 that may be closed by this pull request
@pbullhove pbullhove marked this pull request as ready for review March 11, 2024 10:47
@pbullhove pbullhove requested a review from a team as a code owner March 11, 2024 10:47
Copy link
Contributor

@awesthouse awesthouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the changes 👏🏻 👏🏻 👏🏻

Just commented on a few things that isn't necessarily changes you made, but if you feel like fixing them it would be great 👍🏻

packages/dm-core-plugins/src/job/CronJob.tsx Outdated Show resolved Hide resolved
packages/dm-core-plugins/src/job/CronJob.tsx Outdated Show resolved Hide resolved
packages/dm-core-plugins/src/table/TablePlugin.tsx Outdated Show resolved Hide resolved
@pbullhove pbullhove merged commit 84412e1 into main Mar 11, 2024
8 checks passed
@pbullhove pbullhove deleted the feat/job-control-styling-improvements branch March 11, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(styling): job runner improvement
2 participants