Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use tanstack query to cache attribute and useDocument requests #1436

Merged
merged 4 commits into from
May 31, 2024

Conversation

soofstad
Copy link
Collaborator

What does this pull request change?

  • Replace the most frequent requests (useDocument, and ViewCreator getAttribute) with tanstack/react-query. The cache has a 5sec TTL

Why is this pull request needed?

Performance. Rendering of the "ULS" analysis view goes from 9.5sec -> ~2 when the cache is hot.

Issues related to this change

closes #1433

@soofstad soofstad self-assigned this May 22, 2024
@soofstad soofstad requested a review from a team as a code owner May 22, 2024 13:07
@soofstad soofstad force-pushed the feat/cache-entities branch 4 times, most recently from 501fee7 to e5e039d Compare May 23, 2024 11:25
@soofstad soofstad force-pushed the feat/cache-entities branch 2 times, most recently from 77a46a2 to eb67a3c Compare May 30, 2024 12:26
@soofstad soofstad force-pushed the feat/cache-entities branch from eb67a3c to 3c27175 Compare May 30, 2024 12:40
@soofstad soofstad merged commit 43afa8d into main May 31, 2024
8 checks passed
@soofstad soofstad deleted the feat/cache-entities branch May 31, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: short TTL frontend entity cache
1 participant