Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/more plugin docs #1440

Merged
merged 4 commits into from
May 29, 2024
Merged

Docs/more plugin docs #1440

merged 4 commits into from
May 29, 2024

Conversation

soofstad
Copy link
Collaborator

  • fix the blueprint hierarchy plugin
  • add docs to
    • explorer
    • blueprint hierarchy
    • header
  • delete deprecated pdf plugin

@soofstad soofstad self-assigned this May 28, 2024
@soofstad soofstad requested a review from a team as a code owner May 28, 2024 10:30
Copy link
Contributor

@awesthouse awesthouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯 I was curious if the pdf plugin was a bit redundant

Even tough we're removing docs from the actual rpm package, I do think for our own sake and also for loading time on docs site we should try and reduce file sizes as much as possible so I think it would be better to use JPEGs instead of PNGs. At least on mac OS you can configure screenshot filetype to use JPEG and windows snipping tool also lets use save to JPEG so it shouldn't be too difficult to switch

@soofstad soofstad merged commit 2b9dcf9 into main May 29, 2024
8 checks passed
@soofstad soofstad deleted the docs/more-plugin-docs branch May 29, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants