Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove tailwind #1453

Merged
merged 33 commits into from
Jun 19, 2024
Merged

refactor: remove tailwind #1453

merged 33 commits into from
Jun 19, 2024

Conversation

awesthouse
Copy link
Contributor

@awesthouse awesthouse commented Jun 17, 2024

What does this pull request change?

both packages and example application

  • Switch out tw classNames with layout component and inline styles where necessary
  • Remove tailwind, autoprefixer and postcss from projectsa
  • Cleaned up use of titles and aria-labels for buttons and icon-buttons
  • Some additional aria-attribute improvements
  • Update styles after removal of tailwind reset
  • Remove unnecessary div wrappers, elements and styles/classNames
  • Minor general improvements of semantic HTML and roles

dm-core

  • Stack as layout component in dm-core to avoid dependencies to dm-core-plugins
  • Some style cleanup in ACL components
  • Minor styled-components global styles

dm-core-plugins

  • Expanded Stack functionality to handle more use-cases
  • Use of singular button in ComplexAttributeTitle, not multiple buttons with same onClick
  • Hyperlinkwidget redesign

Why is this pull request needed?

  • Testing easier ways to include css in projects for end-users/no additional import of stylesheets
  • Less dependencies
  • Plugins can "stand on their own" without external style dependencies and resets

@awesthouse awesthouse changed the title Refactor/remove tw plugins refactor: remove tailwind Jun 17, 2024
@awesthouse awesthouse marked this pull request as ready for review June 18, 2024 05:22
@awesthouse awesthouse requested a review from a team as a code owner June 18, 2024 05:22
Copy link
Collaborator

@soofstad soofstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! That's a lot of work 💯

The PR is so big, I really cant properly review it.

  • This must be very thoroughly tested in all the layouts we have, especially SIMPOS. Our track record with big CCS changes is not that great 😛
  • Not sure I see the benefit of using <Stack> for everything. When its just a simple div with flex. Seems like a unnecessary wrapper for many of the places it's used.

@awesthouse
Copy link
Contributor Author

@soofstad Thank you reviewing! It was hard to split in to multiple PR's because it's so connected and it was hard to see if everything was correct until I actually stripped everything away. It's also impossible to read! When you edit wrappers like this it's almost impossible to see the actual changes, but I tried to write the PR description to contain everything that's been done.

I tried not using unnecessary stacks, maybe I missed a few things that can be grouped with a simple div - will definitely take a look!

Truuee, our track record isn't that great, but I have tested a lot! Will pay close attention and test more. I have a PR coming in SIMPOS and will update dm-create-app as well 🙂

@awesthouse awesthouse merged commit 490c024 into main Jun 19, 2024
8 checks passed
@awesthouse awesthouse deleted the refactor/remove-tw-plugins branch June 19, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants