Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/update packages #1467

Merged
merged 9 commits into from
Dec 16, 2024
Merged

Refactor/update packages #1467

merged 9 commits into from
Dec 16, 2024

Conversation

awesthouse
Copy link
Contributor

@awesthouse awesthouse commented Dec 13, 2024

Why is this pull request needed?

  • Need to update packages
  • Package build broken due to linting errors
  • docker-compose not working properly in github runner
  • e2e tests not working properly

What does this pull request change?

  • chore: update packages
  • fix: linting/biome errors and build errors
  • fix: switch docker-compose with docker compose in integration test job
  • fix: e2e test fixes

Most of the changes are

  • added "type" before type imports
  • styled-components filter props, either by filtering with config or prefixing with $
  • use of Number.parseFloat and Number.parseInt instead of global parseFloat and parseInt

@awesthouse awesthouse requested a review from a team as a code owner December 13, 2024 12:16
@@ -56,27 +56,27 @@ jobs:
working-directory: example/

- name: Pull docker images
run: docker-compose pull
Copy link
Contributor Author

@awesthouse awesthouse Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/orgs/community/discussions/116610#discussioncomment-8997411

Might be a better solution for this, but this does the trick. Looks like this has been broken for a while now + this will hopefully fix our healthcheck that has never worked

@awesthouse awesthouse merged commit 8d3c2bc into main Dec 16, 2024
8 checks passed
@awesthouse awesthouse deleted the refactor/update-packages branch December 16, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants