Fixed some typing

equinor · Jan 14, 2025 · 54d5cae · 54d5cae
1 parent 06a619f
commit 54d5cae
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/src/ert/gui/ertwidgets/ensembleselector.py b/src/ert/gui/ertwidgets/ensembleselector.py
@@ -87,11 +87,12 @@ def populate(self) -> None:
                 index = self.count() - 1
                 model_item = model.item(index)
                 assert model_item is not None
-                model_item.setFlags(
+                new_flags = (
                     model_item.flags()
-                    & ~Qt.ItemFlag.ItemIsEnabled
-                    & ~Qt.ItemFlag.ItemIsSelectable
+                    & ~Qt.ItemFlags(Qt.ItemFlag.ItemIsEnabled)
+                    & ~Qt.ItemFlags(Qt.ItemFlag.ItemIsSelectable)
                 )
+                model_item.setFlags(new_flags)
                 self.setItemData(
                     index, "This ensemble is invalid", Qt.ItemDataRole.ToolTipRole
                 )

diff --git a/src/ert/gui/model/real_list.py b/src/ert/gui/model/real_list.py
@@ -1,4 +1,4 @@
-from typing import overload
+from typing import cast, overload
 
 from qtpy.QtCore import (
     QAbstractItemModel,
@@ -72,7 +72,7 @@ def columnCount(self, parent: QModelIndex | None = None) -> int:
     def rowCount(self, parent: QModelIndex | None = None) -> int:
         parent = parent if parent else QModelIndex()
         if not parent.isValid():
-            source_model: SnapshotModel = self.sourceModel()
+            source_model = cast(SnapshotModel, self.sourceModel())
             assert source_model is not None
             iter_index = source_model.index(self._iter, 0, QModelIndex())
             if iter_index.isValid():

diff --git a/src/ert/gui/tools/manage_experiments/storage_model.py b/src/ert/gui/tools/manage_experiments/storage_model.py
@@ -110,9 +110,7 @@ def row(self) -> int:
             return self._parent._children.index(self)
         return 0
 
-    def data(
-        self, index: QModelIndex, role: Qt.ItemDataRole = Qt.ItemDataRole.DisplayRole
-    ) -> Any:
+    def data(self, index: QModelIndex, role: int = Qt.ItemDataRole.DisplayRole) -> Any:
         if not index.isValid():
             return None
 
@@ -230,7 +228,7 @@ def flags(self, index: QModelIndex) -> Qt.ItemFlags:
             return default_flags
         item = index.internalPointer()
         if isinstance(item, ExperimentModel) and not item._is_valid:
-            new_flags = default_flags & ~Qt.ItemFlag.ItemIsEnabled
+            new_flags = default_flags & ~Qt.ItemFlags(Qt.ItemFlag.ItemIsEnabled)
             return Qt.ItemFlags(new_flags)
         return default_flags