fix review comments

equinor · Jun 24, 2024 · a70084c · a70084c
1 parent c647e41
commit a70084c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 10 deletions.
diff --git a/src/ert/gui/simulation/experiment_panel.py b/src/ert/gui/simulation/experiment_panel.py
@@ -152,7 +152,6 @@ def addExperimentConfigPanel(
 
         if not mode_enabled:
             item_count = self._experiment_type_combo.count() - 1
-            combo_model = self._experiment_type_combo.model()
             sim_item = self._experiment_type_combo.model().item(item_count)  # type: ignore
             sim_item.setEnabled(False)
             sim_item.setToolTip("Both observations and parameters must be defined")

diff --git a/src/ert/gui/tools/file/file_dialog.py b/src/ert/gui/tools/file/file_dialog.py
@@ -146,20 +146,18 @@ def _update_cursor(self, value: int) -> None:
     def _enable_follow_mode(self, enable: bool) -> None:
         vertical_scroll_bar = self._view.verticalScrollBar()
         assert vertical_scroll_bar is not None
+        vertical_scroll_bar.setDisabled(enable)
+        self._follow_mode = enable
         if enable:
             self._view.moveCursor(QTextCursor.End)
             self._view.setVerticalScrollBarPolicy(Qt.ScrollBarPolicy.ScrollBarAlwaysOff)
-            vertical_scroll_bar.setDisabled(True)
             self._view.setTextInteractionFlags(Qt.TextInteractionFlag.NoTextInteraction)
-            self._follow_mode = True
         else:
-            vertical_scroll_bar.setDisabled(False)
             self._view.setVerticalScrollBarPolicy(Qt.ScrollBarPolicy.ScrollBarAsNeeded)
             self._view.setTextInteractionFlags(
                 Qt.TextInteractionFlags(Qt.TextInteractionFlag.TextSelectableByMouse)
                 | Qt.TextInteractionFlag.TextSelectableByKeyboard
             )
-            self._follow_mode = False
 
     def _append_text(self, text: str) -> None:
         # Remove trailing newline as appendPlainText adds this

diff --git a/src/ert/gui/tools/plot/customize/customize_plot_dialog.py b/src/ert/gui/tools/plot/customize/customize_plot_dialog.py
@@ -213,9 +213,7 @@ def __init__(
 
         self._tabs = QTabWidget()
         layout.addWidget(self._tabs)
-        layout.setSizeConstraint(
-            QLayout.SizeConstraint.SetFixedSize
-        )  # not resizable!!!
+        layout.setSizeConstraint(QLayout.SizeConstraint.SetFixedSize)
 
         self._button_layout = QHBoxLayout()
 

diff --git a/src/ert/gui/tools/workflows/run_workflow_widget.py b/src/ert/gui/tools/workflows/run_workflow_widget.py
@@ -184,7 +184,7 @@ def workflowFinishedWithFail(self) -> None:
 
         QMessageBox.critical(self, title_text, content_text)
         if self._running_workflow_dialog is not None:
-            self._running_workflow_dialog.accept()
+            self._running_workflow_dialog.reject()
             self._running_workflow_dialog = None
 
     def workflowStoppedByUser(self) -> None:
@@ -195,5 +195,5 @@ def workflowStoppedByUser(self) -> None:
             f"The workflow '{workflow_name}' was killed successfully!",
         )
         if self._running_workflow_dialog is not None:
-            self._running_workflow_dialog.accept()
+            self._running_workflow_dialog.reject()
             self._running_workflow_dialog = None