Skip to content

Commit

Permalink
Fix asof join logic error
Browse files Browse the repository at this point in the history
having "time" in by and on makes it effectively behave as an exact join
  • Loading branch information
yngve-sk committed Feb 4, 2025
1 parent 8432baf commit c1ca814
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/ert/storage/local_ensemble.py
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,10 @@ def get_observations_and_responses(
elif "time" in pivoted:
joined = observations_for_type.join_asof(
pivoted,
by=["response_key", *response_cls.primary_key],
by=[
"response_key",
*[k for k in response_cls.primary_key if k != "time"],
],
on="time",
tolerance="1s",
)
Expand Down

0 comments on commit c1ca814

Please sign in to comment.