Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky adaptive localization test by increasing the ensemble size #6485

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

kvashchuka
Copy link
Contributor

Issue
Resolves #6462

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

Copy link
Contributor

@Blunde1 Blunde1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommyod
Copy link
Contributor

tommyod commented Nov 21, 2023

Please seed the numpy number generator:

cutoff1 = np.random.uniform(0, 1)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f2fdcc) 83.53% compared to head (b0faa2b) 83.52%.
Report is 131 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6485      +/-   ##
==========================================
- Coverage   83.53%   83.52%   -0.01%     
==========================================
  Files         343      345       +2     
  Lines       20759    20705      -54     
  Branches      938      948      +10     
==========================================
- Hits        17340    17294      -46     
+ Misses       3128     3117      -11     
- Partials      291      294       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kvashchuka kvashchuka merged commit 99f9895 into equinor:main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test_adaptive_localization.py::test_that_posterior_generalized_variance_increases_in_cutoff
4 participants