Add support for SUBMIT_SLEEP #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjules
reviewed
Nov 20, 2023
src/ert/job_queue/queue.py
Outdated
| @@ -159,6 +159,12 @@ def count_running(self) -> int: | |||
| for real in self._realizations | |||
| ) | |||
|
|
|||
| def count_submitted(self) -> int: | |||
There was a problem hiding this comment.
Now you can do self.count_realization_state(RealizationState.SUBMITTED)
|
I think you need to rebase |
berland
force-pushed
the
submit_sleep
branch
2 times, most recently
from
8eaea34 to
ce7c01a
Compare
|
Should be ready now, with tests |
xjules
reviewed
Nov 21, 2023
src/ert/job_queue/queue.py
Outdated
| + self.count_realization_state(RealizationState.SUBMITTED) | ||
| < self.max_running() | ||
| ): | ||
| if datetime.datetime.now() - time_of_last_submission >= submit_delta: |
There was a problem hiding this comment.
I thought that this check is not required if we do await asyncio.sleep(self._queue_config.submit_sleep) or?
berland
force-pushed
the
submit_sleep
branch
from
ce7c01a to
7995706
Compare
berland
force-pushed
the
submit_sleep
branch
from
7995706 to
ebc23e0
Compare
Written assuming there will be a global option to set SUBMIT_SLEEP, but will currently pick from the selected queue system.
berland
force-pushed
the
submit_sleep
branch
from
ebc23e0 to
28fba68
Compare
JHolba
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written assuming there will be a global option to set SUBMIT_SLEEP, but will currently pick from the selected queue system.