Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make python lsf driver handle crashes and add lsf queue option #6662

Conversation

jonathan-eq
Copy link
Contributor

Issue
Make lsf python handle crashes in bsub/bkill/bjobs, and add unit tests for this.
Add lsf queue option, and tests for this.
Resolves #6590

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@jonathan-eq jonathan-eq force-pushed the make-python-lsf-driver-handle-crashes branch 3 times, most recently from a69b87b to d694a12 Compare November 24, 2023 19:38
@berland berland force-pushed the make-python-lsf-driver-handle-crashes branch from d694a12 to eebc222 Compare November 27, 2023 05:22
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! I think we lost some unit tests through all the rebasing, but lets add them later.

@berland berland merged commit 3d12038 into equinor:python_jobqueue Nov 27, 2023
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants