-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Adaptive Localization #6682
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6682 +/- ##
=======================================
Coverage 83.78% 83.78%
=======================================
Files 365 365
Lines 21293 21293
Branches 948 948
=======================================
Hits 17841 17841
Misses 3158 3158
Partials 294 294 ☔ View full report in Codecov by Sentry. |
82792a7
to
0e6e057
Compare
ab3a59d
to
708afe6
Compare
Comment on notebooks. In In a hobby project of mine (generalized-additive-models) I had success using bsphinx and config for |
"source": [ | ||
"# Adaptive Localization\n", | ||
"\n", | ||
"Parameter estimation using few samples (realizations) leads to sampling errors and spurious correlations (see Section 1.3), which can lead to inaccurately strong updates during the estimation process.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see section numbering, can we use a link instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not been able to make links work when using nbsphinx
.
I've pushed a fix that just asks the user to see section below... Not great but will have to do for now I think.
I've added a section on computational considerations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Issue
Resolves #6232
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist