Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Adaptive Localization #6682

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Document Adaptive Localization #6682

merged 1 commit into from
Dec 12, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Nov 28, 2023

Issue
Resolves #6232

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (050d02a) 83.78% compared to head (3eb84aa) 83.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6682   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files         365      365           
  Lines       21293    21293           
  Branches      948      948           
=======================================
  Hits        17841    17841           
  Misses       3158     3158           
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda dafeda force-pushed the loc_docs branch 2 times, most recently from 82792a7 to 0e6e057 Compare November 28, 2023 08:23
@dafeda dafeda changed the title Commitin Document Adaptive Localization Nov 28, 2023
@dafeda dafeda self-assigned this Nov 28, 2023
@dafeda dafeda added documentation release-notes:skip If there should be no mention of this in release notes labels Nov 28, 2023
@dafeda dafeda force-pushed the loc_docs branch 4 times, most recently from ab3a59d to 708afe6 Compare November 28, 2023 09:37
@dafeda dafeda marked this pull request as ready for review November 28, 2023 09:45
@tommyod
Copy link
Contributor

tommyod commented Nov 29, 2023

Comment on notebooks.

In iterative_ensemble_smoother we use myst_nb for notebook support. We store py and convert to .ipynb in conf.py.

In a hobby project of mine (generalized-additive-models) I had success using bsphinx and config for jupytext these lines. The end result is pretty much the same, I think: storing py files.

"source": [
"# Adaptive Localization\n",
"\n",
"Parameter estimation using few samples (realizations) leads to sampling errors and spurious correlations (see Section 1.3), which can lead to inaccurately strong updates during the estimation process.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see section numbering, can we use a link instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not been able to make links work when using nbsphinx.
I've pushed a fix that just asks the user to see section below... Not great but will have to do for now I think.

@dafeda
Copy link
Contributor Author

dafeda commented Dec 8, 2023

I've added a section on computational considerations.
I think this is good to go.

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@dafeda dafeda merged commit 374c4b7 into equinor:main Dec 12, 2023
42 checks passed
@dafeda dafeda deleted the loc_docs branch December 12, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Documentation for adaptive localization
5 participants