Raise error on invalid use of runpath placeholders

[andreas-el]

Issue
Resolves #6617

According to FMU-docs:

Deprecated syntax still allow use of two %d specifers. Use of less than two %d is prohibited. The behaviour is identical to the default substitution.

https://fmu-docs.equinor.com/docs/ert/reference/configuration/keywords.html#runpath

Pre review checklist

• Read through the code changes carefully after finishing work
• Make sure tests pass locally (after every commit!)
• Prepare changes in small commits for more convenient review (optional)
• PR title captures the intent of the changes, and is fitting for release notes.
• Updated documentation
• Ensured that unit tests are added for all new behavior (See
  Ground Rules),
  and changes to existing code have good test coverage.

Pre merge checklist

• Added appropriate release note label
• Commit history is consistent and clean, in line with the contribution guidelines.

[larsevj]

LGTM! Just need to change the deprecation test.

[berland]

This would be a breaking change. Running an ensemble experiment on poly with this path works fine.

[andreas-el]

There is a conflict with respect to what the docs state and what the code previously allowed.
Which of these are correct is obviously up for debate.

Docs state;

Use of less than two %d is prohibited

[andreas-el]

The problem detected was mixing the deprecated %d syntax, with the newer <IENS> and <ITER> placeholders. We could allow one %d but at the same time rather check we don't mix the two styles.

Would that be an acceptable solution?

[berland]

The docs are not in accordance with how ert is in use. Not using <ITER> in RUNPATH is normal when doing e.g. prediction runs.

[andreas-el]

Let's update the docs too then.

Using one %d or just <IENS> is okay, but mixing them is not.
Also more than two %d's does also not make sense.

[andreas-el]

Implemented as such.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86a31ef) 83.56% compared to head (a757d71) 83.57%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6731      +/-   ##
==========================================
+ Coverage   83.56%   83.57%   +0.01%     
==========================================
  Files         359      359              
  Lines       20952    20956       +4     
  Branches      948      948              
==========================================
+ Hits        17509    17515       +6     
+ Misses       3149     3147       -2     
  Partials      294      294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[larsevj]

Is this Error message a little too generic? It might be difficult to figure out what you did wrong? Especially if we are still supporting other types of runpath, than the DEFAULT one?

[andreas-el]

Is this Error message a little too generic? It might be difficult to figure out what you did wrong? Especially if we are still supporting other types of runpath, than the DEFAULT one?

That's a good point. Lets make them more specific to convey more information.

[larsevj]

LGTM 👍