Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lsf unit tests and fix lsf integration test #6739

Closed
wants to merge 4 commits into from

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Dec 1, 2023

Depends on #6643
Resolves #6721

@jonathan-eq jonathan-eq requested a review from xjules December 1, 2023 14:18
@jonathan-eq jonathan-eq force-pushed the jonak-new branch 3 times, most recently from 1505e7a to dfa61ff Compare December 4, 2023 07:59
@xjules
Copy link
Contributor

xjules commented Dec 4, 2023

Is this rebased already?

assert not Path("bjobs_logs").exists()

output = caplog.text
assert output == ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is perhaps a little fragile, as it does not assert our wanted behaviour, only what we log, which we might want to change for other reasons later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, as long as it does not crash it should be fine

asyncio.create_task(self.jobqueue.driver.submit(self))
task = asyncio.create_task(self._submit_async())
self.background_tasks.add(task)
task.add_done_callback(self.background_tasks.discard)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we treat exceptions when the task fails?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callback calls self.somethingwentwrong() and the exception is re-raised. But it seems like the re-raised exception disappears somewhere in the statemachine.

@xjules
Copy link
Contributor

xjules commented Dec 15, 2023

I guess this goes back to backlog

@jonathan-eq
Copy link
Contributor Author

Closing this as it is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants