Implement MockDriver #6788
Merged
Implement MockDriver #6788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkwah
force-pushed
the
taskdriver
branch
2 times, most recently
from
ed21dd5 to
159b0c7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6788 +/- ##
=======================================
Coverage 83.88% 83.88%
=======================================
Files 365 365
Lines 21383 21398 +15
Branches 948 948
=======================================
+ Hits 17937 17950 +13
- Misses 3152 3154 +2
Partials 294 294 ☔ View full report in Codecov by Sentry. |
berland
reviewed
Dec 12, 2023
berland
reviewed
Dec 12, 2023
| driver = MockDriver(init=init) | ||
|
|
||
| sch = scheduler.Scheduler(driver) | ||
| sch.add_realization(realization, callback_timeout=lambda _: None) |
There was a problem hiding this comment.
can remove callback_timeout from this function call.
berland
reviewed
Dec 12, 2023
xjules
reviewed
Dec 12, 2023
berland
reviewed
Dec 13, 2023
pinkwah
force-pushed
the
taskdriver
branch
2 times, most recently
from
bf5137f to
d710981
Compare
pinkwah
force-pushed
the
taskdriver
branch
2 times, most recently
from
e2834d8 to
0470e9c
Compare
pinkwah
added
the
release-notes:skip
pinkwah
force-pushed
the
taskdriver
branch
6 times, most recently
from
b6fe7c6 to
10243a3
Compare
LocalDriver differs from the HPC drivers in that it is made of three parts that are run in sequence. `init` the subprocess, `wait` for the process to complete and `kill` when the user wants to cancel. Between the three parts the driver needs to send `JobEvent`s to the `Scheduler`. This commit implements a `MockDriver`, where the user can optionally specify a simplified version of each of `init`, `wait` or `kill`, depending on what they wish to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalDriver differs from the HPC drivers in that it is made of three
parts that are run in sequence.
initthe subprocess,waitfor theprocess to complete and
killwhen the user wants to cancel. Betweenthe three parts the driver needs to send
JobEvents to theScheduler.This commit implements a
MockDriver, where the user can optionallyspecify a simplified version of each of
init,waitorkill,depending on what they wish to do.