Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise if params not registered are saved #6793

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Raise if params not registered are saved #6793

merged 1 commit into from
Dec 14, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Dec 13, 2023

Issue
Resolves #6735

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda self-assigned this Dec 13, 2023
@dafeda dafeda added bug release-notes:skip If there should be no mention of this in release notes labels Dec 13, 2023
kvashchuka
kvashchuka approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@kvashchuka kvashchuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@dafeda dafeda merged commit f3063c4 into equinor:main Dec 14, 2023
40 of 42 checks passed
@dafeda dafeda deleted the register_params branch December 14, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvashchuka kvashchuka kvashchuka approved these changes

Assignees

@dafeda dafeda

Labels
bug release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible to save any dataset to ensemble without registering to experiment
2 participants
@dafeda @kvashchuka