Remove the state map for ensembles #6797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
force-pushed
the
fix-state-map
branch
from
a5843d7 to
260198c
Compare
frode-aarstad
changed the title
frode-aarstad
changed the title
frode-aarstad
force-pushed
the
fix-state-map
branch
3 times, most recently
from
cd1d739 to
2efa80c
Compare
frode-aarstad
force-pushed
the
fix-state-map
branch
from
2efa80c to
7109b65
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6797 +/- ##
==========================================
- Coverage 83.79% 83.79% -0.01%
==========================================
Files 368 368
Lines 21684 21660 -24
Branches 948 948
==========================================
- Hits 18171 18149 -22
+ Misses 3219 3217 -2
Partials 294 294 ☔ View full report in Codecov by Sentry. |
frode-aarstad
force-pushed
the
fix-state-map
branch
2 times, most recently
from
7a1676e to
390defc
Compare
dafeda
reviewed
Jan 3, 2024
dafeda
reviewed
Jan 3, 2024
| prior_ensemble=ensemble_1, | ||
| ) | ||
| assert _cases(storage) == ["foo1", "foo2"] | ||
| assert ( |
There was a problem hiding this comment.
Both this test and test_create_ensemble_from_prior end with the same assert. Is it enough to have one of them?
There was a problem hiding this comment.
Good catch. Not really needed with two tests here
dafeda
reviewed
Jan 3, 2024
| @@ -62,11 +61,7 @@ def test_simulation_context(setup_case, storage, monkeypatch, try_queue_and_sche | |||
| assert even_ctx.didRealizationSucceed(iens) | |||
| assert not even_ctx.didRealizationFail(iens) | |||
| assert even_ctx.isRealizationFinished(iens) | |||
|
|
|||
| assert even_half.state_map[iens] == RealizationStorageState.HAS_DATA | |||
There was a problem hiding this comment.
Add a different assert here or OK to remove?
There was a problem hiding this comment.
Should be safe to remove as this test only simulates and not run any analysis thus has no data
dafeda
reviewed
Jan 3, 2024
| else: | ||
| assert odd_ctx.didRealizationSucceed(iens) | ||
| assert not odd_ctx.didRealizationFail(iens) | ||
| assert odd_ctx.isRealizationFinished(iens) | ||
|
|
||
| assert odd_half.state_map[iens] == RealizationStorageState.HAS_DATA |
There was a problem hiding this comment.
Add a different assert here or OK to remove?
dafeda
reviewed
Jan 3, 2024
dafeda
reviewed
Jan 3, 2024
| active_realizations: List[bool], | ||
| ) -> int: | ||
| """Returns the number of loaded realizations""" | ||
| pool = ThreadPool(processes=8) |
There was a problem hiding this comment.
Just curious, why 8 threads?
There was a problem hiding this comment.
I just moved this code so I dont know
dafeda
approved these changes
Jan 3, 2024
frode-aarstad
force-pushed
the
fix-state-map
branch
3 times, most recently
from
deb173d to
4cdfe3e
Compare
frode-aarstad
force-pushed
the
fix-state-map
branch
from
4cdfe3e to
a2ad95d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #6736
Approach
Remove the state map from local_ensemble.py. This is replaced by checking the state based on the actual files present in the ensemble directory on disk. We also store any errors with a possible error message on disk in the ensemble.
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist