Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove X_local from global update #6818

Closed
wants to merge 3 commits into from
Closed

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Dec 16, 2023

Do in-place matrix multiplaction

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f30d83a) 83.88% compared to head (f257586) 83.88%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/ert/analysis/_es_update.py 94.44% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6818   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files         365      365           
  Lines       21444    21449    +5     
  Branches      948      948           
=======================================
+ Hits        17988    17993    +5     
  Misses       3162     3162           
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda dafeda force-pushed the refactor_update branch 5 times, most recently from f257586 to c765c7f Compare December 19, 2023 13:10
@dafeda dafeda closed this Jun 13, 2024
@dafeda dafeda deleted the refactor_update branch June 13, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants