-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark status tests for testing with Scheduler #6819
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6819 +/- ##
==========================================
- Coverage 83.88% 83.86% -0.02%
==========================================
Files 365 365
Lines 21383 21383
Branches 948 948
==========================================
- Hits 17937 17933 -4
- Misses 3152 3156 +4
Partials 294 294 ☔ View full report in Codecov by Sentry. |
732a776
to
9416c09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a minor typo in commit message Mark status tests for testing with cheduler
.
Also, it seems like most of those tests are integration tests and not unit tests, so they might have already been moved (and had the fixtures added) in a unmerged/blocked PR #6787
Should I rebase the other PR?
These are currently skipped
9416c09
to
b2a8188
Compare
Fixed typo. If 6787 is merged, I will rebase this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
These are currently skipped
Issue
Resolves part of #6810
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist