Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark status tests for testing with Scheduler #6819

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

berland
Copy link
Contributor

@berland berland commented Dec 18, 2023

These are currently skipped

Issue
Resolves part of #6810

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4230ff) 83.88% compared to head (9416c09) 83.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6819      +/-   ##
==========================================
- Coverage   83.88%   83.86%   -0.02%     
==========================================
  Files         365      365              
  Lines       21383    21383              
  Branches      948      948              
==========================================
- Hits        17937    17933       -4     
- Misses       3152     3156       +4     
  Partials      294      294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland changed the title Mark status tests for testing with cheduler Mark status tests for testing with Scheduler Dec 18, 2023
@berland berland marked this pull request as ready for review December 18, 2023 13:10
@berland berland self-assigned this Dec 18, 2023
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Dec 18, 2023
@jonathan-eq jonathan-eq self-requested a review December 19, 2023 11:27
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minor typo in commit message Mark status tests for testing with cheduler.

Also, it seems like most of those tests are integration tests and not unit tests, so they might have already been moved (and had the fixtures added) in a unmerged/blocked PR #6787
Should I rebase the other PR?

@berland
Copy link
Contributor Author

berland commented Dec 20, 2023

Fixed typo. If 6787 is merged, I will rebase this.

@jonathan-eq jonathan-eq self-requested a review December 20, 2023 12:57
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berland berland merged commit 5d32855 into equinor:main Dec 20, 2023
44 checks passed
@berland berland deleted the mark_test_tracking branch June 6, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants