Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample a single value instead of ensemble_size #6866

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Dec 30, 2023

It is not necessary to sample #ensemble_size values and then discard all but one.
This instead advances the rng using the realization number and then samples just one value.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

Sorry, something went wrong.

It is not necessary to sample #ensemble_size values
and then discard all but one.
This instead advances the rng using the realization number
and then samples just one value.
@dafeda dafeda self-assigned this Dec 30, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0962817) 83.96% compared to head (8e97979) 83.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6866   +/-   ##
=======================================
  Coverage   83.96%   83.96%           
=======================================
  Files         368      368           
  Lines       21541    21542    +1     
  Branches      948      948           
=======================================
+ Hits        18086    18087    +1     
  Misses       3161     3161           
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Jan 2, 2024
@dafeda dafeda merged commit cad295e into equinor:main Jan 2, 2024
44 checks passed
@dafeda dafeda deleted the sampling branch January 2, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants