Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce accuracy of surface-order test #6901

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Jan 4, 2024

Test is flaky.
Test makes sure ERT does not change order of arrays and numerical accuracy is not important.

Issue
Resolves #6898

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Test is flaky.
Test makes sure ERT does not change order of arrays and numerical
accuracy is not important.
@dafeda dafeda self-assigned this Jan 4, 2024
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 5, 2024
@oyvindeide oyvindeide merged commit 8c22f23 into equinor:main Jan 5, 2024
44 checks passed
@dafeda dafeda deleted the flaky_surface branch January 9, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_that_surfaces_retain_their_order_when_loaded_and_saved_by_ert is flaky
2 participants