Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get progress from adaptive localization #7114

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Feb 6, 2024

Resolves: #6946

NB! This requires a release of iterative_ensemble_smoother that has this fix:

equinor/iterative_ensemble_smoother#212

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@dafeda dafeda self-assigned this Feb 6, 2024
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Feb 6, 2024
@dafeda dafeda force-pushed the adloc_progress_callback branch 2 times, most recently from d6e6b2c to ad4881f Compare February 6, 2024 07:29
@dafeda dafeda force-pushed the adloc_progress_callback branch 2 times, most recently from 27cc0ab to a8331ea Compare February 6, 2024 09:07
@dafeda dafeda closed this Feb 6, 2024
@dafeda dafeda reopened this Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c2b600) 85.24% compared to head (a74b9d7) 85.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7114      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.02%     
==========================================
  Files         379      379              
  Lines       22551    22555       +4     
  Branches     1033     1022      -11     
==========================================
+ Hits        19223    19232       +9     
+ Misses       3216     3208       -8     
- Partials      112      115       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please unpin iterative_ensemble_smoother before you merge: #7119

@dafeda dafeda force-pushed the adloc_progress_callback branch from a8331ea to a74b9d7 Compare February 7, 2024 05:22
@dafeda dafeda merged commit 7522112 into equinor:main Feb 7, 2024
51 checks passed
@dafeda dafeda deleted the adloc_progress_callback branch February 7, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show remaining and elapsed time during adaptive localization
4 participants