-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify simulation arguments to run models #8140
Conversation
448e946
to
3031204
Compare
1727479
to
040a5f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8140 +/- ##
==========================================
- Coverage 86.62% 86.56% -0.06%
==========================================
Files 384 384
Lines 23831 23773 -58
Branches 618 627 +9
==========================================
- Hits 20644 20580 -64
- Misses 3107 3112 +5
- Partials 80 81 +1 ☔ View full report in Codecov by Sentry. |
b6c3870
to
e238e0d
Compare
4de603f
to
5a9465a
Compare
Semeio failure is expected, fix here: equinor/semeio#624 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
This also removes redundant check for active realizations as this is already checked in validate(), which happens earlier
5a9465a
to
1c57949
Compare
The intention here is to reduce the statefullness of the run models, by reducing the use of simulation arguments as holders of state, and internalizing state on the run models instead. Also to simplify the simulation arguments by removing a lot of unneeded properties.
This results in a breaking change for the cli, which aligns it with the GUI in terms of naming the ensembles in ensemble smoother.
Closes #7633
When applicable