Only log INFO messages from websockets #8165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
changed the title
berland
added
the
release-notes:misc
By going from logging DEBUG messages to INFO and above, we shave 95% off the log size when doing the poly-example. Logging has been proven to be a bottleneck so this change could actually improve perceived application speed. Not opting to filter out INFO as well for the moment, meaning we will still log whenever the connection is closed and reopened (which we don't want to happen so it makes sense to log it).
berland
force-pushed
the
tune-websocket-log-level
branch
from
7353650 to
1a9dc6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8161
Resolves speed issue for Ert, according to @JHolba excessive time is spent by websocket.serve() due to logging.
Approach
✂️
When applicable